Fix TopologySpread bug that evicts non-evictable pods #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/priority critical-urgent |
k8s-ci-robot
added
the
priority/critical-urgent
damemi
removed
the
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
LGTM |
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
Fix TopologySpread bug that evicts non-evictable pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopologySpreadConstraint does not properly check if a pod is evictable before calling
EvictPod(due to the fact that it does not rely onListPodsOnNode, which takesIsEvictableas a parameter and does the check there for most of the other strategies).This breaks the check out explicitly. It could also be refactored to do this check in
balanceDomains, when building the list of evictable pods.