Log and README optimization for LowNodeUtilization #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
/assign @damemi |
lixiang233
commented
Feb 20, 2021
Comment on lines
-130
to
-133
| if len(lowNodes) == len(nodes) { | ||
| klog.V(1).InfoS("All nodes are underutilized, nothing to do here") | ||
| return | ||
| } |
There was a problem hiding this comment.
This case is included in len(targetNodes) == 0
ingvagabund
requested changes
Feb 22, 2021
lixiang233
force-pushed
the
Fix_lowNodeUtilization_log
branch
from
4257fd2
to
ecafb88
Compare
damemi
reviewed
Feb 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, lixiang233 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
lixiang233
force-pushed
the
Fix_lowNodeUtilization_log
branch
from
ecafb88
to
e014fda
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…lization_log Log and README optimization for LowNodeUtilization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #500
/kind cleanup