Add table of contents generator/verify scripts #516
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| source "$(dirname "${BASH_SOURCE}")/lib/init.sh" | ||
|
|
||
| # forked from github.com/ekalinin/github-markdown-toc/gh-md-toc | ||
| wget -O ${OS_OUTPUT_BINPATH}/gh-md-toc https://raw.githubusercontent.com/damemi/github-markdown-toc/hide-footer/gh-md-toc |
There was a problem hiding this comment.
Should the gh-md-toc script just be added to the descheduler repo instead of downloading it from another repo?
There was a problem hiding this comment.
What about to duplicate https://github.com/kubernetes-sigs/metrics-server/blob/master/Makefile#L177-L189 ? Looks quite shorter.
There was a problem hiding this comment.
Oh sweet, I did not even know there was a k8s toc generator already. I'll update to use that instead.
We can vendor it like we do with our other generators so it doesn't have to be downloaded each time.
|
/close |
|
@damemi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
@damemi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@damemi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds scripts to generate and verify that the README table of contents is updated
/kind feature