-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document That Descheduler Considers StatefulSets For Eviction #520
Document That Descheduler Considers StatefulSets For Eviction #520
Conversation
/kind documentation Part of #519 |
fecdc03
to
7180526
Compare
@seanmalloy worth mentioning StatefulSet in https://github.com/kubernetes-sigs/descheduler/blame/master/README.md#L549 as well. |
I believe I already took care of this, but let me know if I'm not understanding correctly. |
Right, sorry, looking into wrong README.md :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@damemi and @ingvagabund I added the initial unit tests for StatefulSets. This PR is ready for review again. If it is alright with you I will add the StatefulSet e2e tests in a separate PR. |
Also, I can squash the two documentation commits into a single commit once we think the changes are good. |
Looks good, please squash |
Similar to ReplicaSet, ReplicationController, and Jobs pods with a StatefulSet metadata.ownerReference are considered for eviction. Document this, so that it is clear to end users.
85fcd15
to
92740a2
Compare
@ingvagabund and @damemi it is squashed into two commits. One for the doc updates and one for the unit test updates. |
/lgtm |
…et-docs Document That Descheduler Considers StatefulSets For Eviction
Similar to ReplicaSet, ReplicationController, and Jobs pods with a
StatefulSet metadata.ownerReference are considered for eviction.
Document this, so that it is clear to end users.