Invert main strategy loop for performance and customizability #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ingvagabund
reviewed
Apr 27, 2021
damemi
force-pushed
the
change-main-loop
branch
from
602980f
to
bc65881
Compare
k8s-ci-robot
added
size/S
ingvagabund
reviewed
Apr 28, 2021
pkg/descheduler/descheduler.go
Outdated
| f(ctx, rs.Client, strategy, nodes, podEvictor) | ||
| } | ||
| } else { | ||
| klog.Errorf("Unknown strategy name '%s', exiting", name) |
There was a problem hiding this comment.
Maybe skipping instead of exiting? Exiting might give impression the descheduler is aborting actually.
There was a problem hiding this comment.
Oh, yeah I actually am just skipping... updated the message to say that
damemi
force-pushed
the
change-main-loop
branch
from
bc65881
to
feae158
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
Invert main strategy loop for performance and customizability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while thinking about the new API options we started discussing in #486
Right now we are checking against every strategy function and then seeing if it's enabled. This does 2 things:
Wastes time for strategies that aren't enabled
Only allows strategies to be run in a fixed order
is probably negligible, but 2. is something we should consider providing. I don't know if the current order is hardcoded for a reason. There also hasn't been any demand for this specific functionality that I know of, but while we are considering improvements to the API I think a change like this could make it more flexible.
Either way, this does also add an error for invalid strategy names (where it currently just silently skips them)