Add test cases for soft constraints/multi constraints #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
damemi
commented
May 10, 2021
| @@ -126,7 +126,7 @@ func RemovePodsViolatingTopologySpreadConstraint( | |||
| for _, pod := range namespacePods.Items { | |||
| for _, constraint := range pod.Spec.TopologySpreadConstraints { | |||
| // Ignore soft topology constraints if they are not included | |||
| if (strategy.Params == nil || !strategy.Params.IncludeSoftConstraints) && constraint.WhenUnsatisfiable != v1.DoNotSchedule { | |||
| if constraint.WhenUnsatisfiable == v1.ScheduleAnyway && (strategy.Params == nil || !strategy.Params.IncludeSoftConstraints) { | |||
There was a problem hiding this comment.
changed this to be a bit more readable
There was a problem hiding this comment.
+1 for inclusion, not exclusion
damemi
force-pushed
the
issue-564
branch
2 times, most recently
from
a0f160b
to
5ae5690
Compare
k8s-ci-robot
added
size/L
damemi
force-pushed
the
issue-564
branch
2 times, most recently
from
3f8ceb9
to
9faad05
Compare
damemi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Turns out there wasn't actually a bug with this, but we should still have these test cases anyway |
lixiang233
reviewed
May 12, 2021
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
Add test cases for soft constraints/multi constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
/kind bug