-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding clarification to HighNodeUtilization's purpose #592
docs: adding clarification to HighNodeUtilization's purpose #592
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @chrisjohnson00! |
Hi @chrisjohnson00. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approve
thanks @chrisjohnson00, after @ingvagabund's comment I think this helps.
You'll also need to sign the CLA before this will merge. Thanks again!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisjohnson00, damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla |
/retest |
/lgtm |
I signed it yesterday, but |
That's odd, usually it should pick it up pretty quick. Maybe the bot is just delayed right now for some reason, if it doesn't update we can look into it |
/check-cla |
1 similar comment
/check-cla |
/retest |
@chrisjohnson00 I'm not sure why the CLA check isn't passing for you, perhaps you could try filling it out again? You could also ask in #sig-contribex on k8s slack and they should be able to help |
/check-cla |
1 similar comment
/check-cla |
Woohoo!! |
/kind documentation |
docs: adding clarification to HighNodeUtilization's purpose
This PR resolves issue #591