Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding clarification to HighNodeUtilization's purpose #592

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

chrisjohnson00
Copy link
Contributor

This PR resolves issue #591

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 24, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @chrisjohnson00!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @chrisjohnson00. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
@chrisjohnson00 chrisjohnson00 marked this pull request as ready for review June 24, 2021 23:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2021
@chrisjohnson00
Copy link
Contributor Author

I've signed the CLA

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
thanks @chrisjohnson00, after @ingvagabund's comment I think this helps.

You'll also need to sign the CLA before this will merge. Thanks again!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisjohnson00, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@chrisjohnson00
Copy link
Contributor Author

/check-cla

@chrisjohnson00
Copy link
Contributor Author

/retest

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@chrisjohnson00
Copy link
Contributor Author

You'll also need to sign the CLA before this will merge. Thanks again!

I signed it yesterday, but /check-cla doesn't seem to be clearing the check... what can I do here?

@damemi
Copy link
Contributor

damemi commented Jun 25, 2021

That's odd, usually it should pick it up pretty quick. Maybe the bot is just delayed right now for some reason, if it doesn't update we can look into it

@chrisjohnson00
Copy link
Contributor Author

/check-cla

1 similar comment
@ingvagabund
Copy link
Contributor

/check-cla

@a7i
Copy link
Contributor

a7i commented Jul 27, 2021

/retest

@damemi
Copy link
Contributor

damemi commented Jul 30, 2021

@chrisjohnson00 I'm not sure why the CLA check isn't passing for you, perhaps you could try filling it out again? You could also ask in #sig-contribex on k8s slack and they should be able to help

@chrisjohnson00
Copy link
Contributor Author

/check-cla

1 similar comment
@chrisjohnson00
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 13, 2021
@chrisjohnson00
Copy link
Contributor Author

Woohoo!!

@k8s-ci-robot k8s-ci-robot merged commit 6ad6f6f into kubernetes-sigs:master Aug 13, 2021
@chrisjohnson00 chrisjohnson00 deleted the issue-591 branch August 13, 2021 23:23
@seanmalloy
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 20, 2021
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
docs: adding clarification to HighNodeUtilization's purpose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants