-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore pods being deleted #621
Ignore pods being deleted #621
Conversation
Welcome @uthark! |
Hi @uthark. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @damemi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
3b73dfa
to
3ca76e5
Compare
/retest |
@damemi tests are passing now. |
/retest Previous run failed with
|
3ca76e5
to
aabf85d
Compare
/retest |
"sigs.k8s.io/descheduler/pkg/api" | ||
"testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know the reason why moving this from L6 to L7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was auto format in the IDE, reverted the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
`
./hack/verify-govet.sh
./hack/verify-spelling.sh
./hack/verify-gofmt.sh
!!! 'gofmt -s' needs to be run on the following files:
./pkg/descheduler/strategies/topologyspreadconstraint_test.go
make: *** [Makefile:107: verify-gofmt] Error 1
aabf85d
to
20ae05d
Compare
@uthark: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉awesome!
As a follow-up, some of the other strategies could benefit from this as well. Possibly a good place would be ListPodsOnANode), for those that use that.
20ae05d
to
4448d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i, damemi, uthark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Ignore pods being deleted
Closes #618