Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for cronjob suspend #622

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Added support for cronjob suspend #622

merged 1 commit into from
Sep 22, 2021

Conversation

yutachaos
Copy link
Contributor

Added support for cronjob suspend

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @yutachaos!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yutachaos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2021
@yutachaos
Copy link
Contributor Author

/assign @seanmalloy

damemi
damemi reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2021
@yutachaos yutachaos force-pushed the feature/added_suspend_parameter branch from bbcf848 to f66c455 Compare September 9, 2021 05:09
@yutachaos
Copy link
Contributor Author

/retest-required

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 10, 2021 •
edited
Loading

@yutachaos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-test-e2e-k8s-1-21-1-21 f66c455 link /test pull-descheduler-test-e2e-k8s-1-21-1-21

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yutachaos
Added helm chart suspend parameter
cf219fb 
Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
@yutachaos yutachaos force-pushed the feature/added_suspend_parameter branch from f66c455 to cf219fb Compare September 16, 2021 05:32
@yutachaos
Copy link
Contributor Author

/retest-required

damemi
damemi reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, yutachaos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@damemi
Copy link
Contributor

damemi commented Sep 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9263395 into kubernetes-sigs:master Sep 22, 2021
@yutachaos yutachaos deleted the feature/added_suspend_parameter branch September 25, 2021 12:14
@seanmalloy seanmalloy mentioned this pull request Oct 1, 2021
Merged
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#622 from yutachaos/feature/added_s…
264ef44 
…uspend_parameter

Added support for cronjob suspend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@seanmalloy seanmalloy

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yutachaos @k8s-ci-robot @damemi @seanmalloy