README: Clarify podRestartThreshold applying to the sum over containers

[wking]

calcContainerRestarts sums over containers. The new language makes that clear, avoiding potential confusion vs. an altenative that looked for pods where a single container had passed the configured threshold. For example, with three containers with 50 restarts and a threshold of 100, the actual "sum over containers" logic makes that pod a candidate for descheduling, but the "largest single container restart count" hypothetical would not have made it a candidate.

Also shifts labelSelector into the parameter table, because when it was added in 29ade13 (#510), it landed a few lines too high.

[k8s-ci-robot]

Welcome @wking!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @wking. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damemi]

/ok-to-test
/lgtm

[wking]

panic: send on closed channel must be unrelated to my Markdown-only change. run_if_changed: \.go$ might be a useful addition to your Go-unit presubmit config.

[damemi]

Good suggestion @wking! I have opened a PR here to do just that: kubernetes/test-infra#23956

[ingvagabund]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment