Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip to informers #674

Closed
wants to merge 2 commits into from
Closed

Flip to informers #674

wants to merge 2 commits into from

Conversation

ingvagabund
Copy link
Contributor

Use pod lister and client side field filtering instead of directly listing pods through a clientset and using field selector.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-test-e2e-k8s-master-1-21 357eea5 link true /test pull-descheduler-test-e2e-k8s-master-1-21
pull-descheduler-test-e2e-k8s-master-1-20 357eea5 link true /test pull-descheduler-test-e2e-k8s-master-1-20
pull-descheduler-test-e2e-k8s-master-1-22 357eea5 link true /test pull-descheduler-test-e2e-k8s-master-1-22

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund ingvagabund mentioned this pull request Dec 13, 2021
Merged
@ingvagabund
Copy link
Contributor Author

Closing in favor of #673

@ingvagabund ingvagabund deleted the flip-to-informers branch December 14, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingvagabund @k8s-ci-robot