Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Backport context cancel panic + Go version update #742

Merged
merged 3 commits into from
Feb 28, 2022
Merged

[release-1.23] Backport context cancel panic + Go version update #742

merged 3 commits into from
Feb 28, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Feb 25, 2022 •
edited
Loading

Backports #731 and preps for a v0.23.1 app release to address this

Fixes #743
ref #741 #728

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
damemi
damemi commented Feb 25, 2022
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @seanmalloy @ingvagabund
ptal, this seems to be affecting more people

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 25, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2022
@damemi damemi changed the title [release-1.23] Backport context cancel panic [release-1.23] Backport context cancel panic + Go version update Feb 25, 2022
@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2022

Also included the commit from #744, which needs CLA check first

@damemi damemi mentioned this pull request Feb 25, 2022
Merged
@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2022

/check-cla

@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2022
@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@damemi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2022

/reopen

@k8s-ci-robot
Copy link
Contributor

@damemi: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 25, 2022
@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2022

/check-cla

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi
Copy link
Contributor Author

damemi commented Feb 28, 2022

/check-cla

@agurgel-te @damemi
Update golang image
1712879 
1.17.3 is affected by CVE-2021-44716.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 28, 2022
@damemi
Copy link
Contributor Author

damemi commented Feb 28, 2022

@seanmalloy could you please re-tag? CLA check is passed now but I pulled in a new change (1.17.7 instead of .6)

@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9ed7f93 into kubernetes-sigs:release-1.23 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund approved these changes

@lixiang233 lixiang233 Awaiting requested review from lixiang233

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damemi @seanmalloy @k8s-ci-robot @ingvagabund @jklaw90 @agurgel-te