-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RemovePodsViolatingNodeTaints taint exclusion #777
Add RemovePodsViolatingNodeTaints taint exclusion #777
Conversation
Welcome @JacobHenner! |
Hi @JacobHenner. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, the rest looks great!!! Thank You for noticing this and fixing it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind squashing the commits?
Add taint exclusion to RemovePodsViolatingNodeTaints. This permits node taints to be ignored by allowing users to specify ignored taint keys or ignored taint key=value pairs.
a89bbd0
to
ac33621
Compare
@JacobHenner much appreciated |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, JacobHenner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add taint exclusion to RemovePodsViolatingNodeTaints. This permits node
taints to be ignored by allowing users to specify ignored taint keys or
ignored taint key=value pairs.
Fixes #772