-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version command to parse helm chart tags #823
Conversation
/hold |
/hold cancel
vs the old
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Using
--match "v*"
actually matches on thedescheduler-helm-chart-
tags as well since we prefix all automated build tags withv2022..
date timestamps. This updates theversion
command to just add another use cases for scenarios where helm chart tags are the most recent ones.Related: #736 (comment)
I tried putting together a release process to address this when we're doing a release, but that just means we have a race between the chart-releaser action and the image auto builder. This is more of an actual fix