Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version command to parse helm chart tags #823

Merged
merged 1 commit into from
May 31, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 31, 2022

Using --match "v*" actually matches on the descheduler-helm-chart- tags as well since we prefix all automated build tags with v2022.. date timestamps. This updates the version command to just add another use cases for scenarios where helm chart tags are the most recent ones.

Related: #736 (comment)

I tried putting together a release process to address this when we're doing a release, but that just means we have a race between the chart-releaser action and the image auto builder. This is more of an actual fix

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2022
@damemi
Copy link
Contributor Author

damemi commented May 31, 2022

/hold
still testing this

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@damemi
Copy link
Contributor Author

damemi commented May 31, 2022

/hold cancel
updated to print the patch version as well, ie:

Descheduler version {Major:0 Minor:24.1 GitVersion:v20220531-descheduler-helm-chart-0.24.1-1-g55ab0deaf GitBranch:1.24-fix-version-cmd GitSha1:55ab0deaf7ab34395ce4b9c01d8827a5bebbe1b6 BuildDate:2022-05-31T17:39:42+0000 GoVersion:go1.19-pre2 cl/451353751 +37eae7ce94 Compiler:gc Platform:linux/amd64}

vs the old

Descheduler version {Major:0 Minor:24+ GitVersion:v20220531-descheduler-helm-chart-0.24.1-1-g55ab0deaf GitBranch:1.24-fix-version-cmd GitSha1:55ab0deaf7ab34395ce4b9c01d8827a5bebbe1b6 BuildDate:2022-05-31T17:39:42+0000 GoVersion:go1.19-pre2 cl/451353751 +37eae7ce94 Compiler:gc Platform:linux/amd64}

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@damemi
Copy link
Contributor Author

damemi commented May 31, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8972bd9 into kubernetes-sigs:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants