Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodLifeTime: sort pods by creation timestamp #833

Merged
merged 2 commits into from
Jun 7, 2022
Merged

PodLifeTime: sort pods by creation timestamp #833

merged 2 commits into from
Jun 7, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jun 5, 2022

Closes #816

In the event that PDB or settings such maxNoOfPodsToEvictPer* prevent too much eviction, we need to make sure that oldest pod is evicted first.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2022
@a7i a7i marked this pull request as ready for review June 5, 2022 02:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from damemi and k82cn June 5, 2022 02:27
@ingvagabund
Copy link
Contributor

/test all

@a7i
Copy link
Contributor Author

a7i commented Jun 6, 2022

/retest

1 similar comment
@JaneLiuL
Copy link
Member

JaneLiuL commented Jun 7, 2022

/retest

@a7i
Copy link
Contributor Author

a7i commented Jun 7, 2022

I think it's because of the pointer lib: "k8s.io/utils/pointer"

@ingvagabund
Copy link
Contributor

/assign

@ingvagabund
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 98a946d into kubernetes-sigs:master Jun 7, 2022
@a7i a7i deleted the podlifetime-sort-age branch June 7, 2022 12:39
@a7i a7i mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund approved these changes

@lixiang233 lixiang233 Awaiting requested review from lixiang233

@damemi damemi Awaiting requested review from damemi

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Descheduler should sort pods by age for PodLifeTime
4 participants
@a7i @k8s-ci-robot @ingvagabund @JaneLiuL