Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run: gofumpt -w -extra . #969

Merged
merged 1 commit into from
Nov 8, 2022
Merged

run: gofumpt -w -extra . #969

merged 1 commit into from
Nov 8, 2022

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Sep 30, 2022

Enable gofumpt in golangci

Signed-off-by: Furkan furkan.turkal@trendyol.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Dentrax. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2022
@a7i
Copy link
Contributor

a7i commented Sep 30, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2022
@a7i
Copy link
Contributor

a7i commented Sep 30, 2022

I can see a few other sigs projects are using gofumpt 👍🏼
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
damemi
damemi reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but could we add it to the makefile so people can easily update when their PRs fail?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@Dentrax
Copy link
Contributor Author

Dentrax commented Sep 30, 2022

lgtm, but could we add it to the makefile so people can easily update when their PRs fail?

Make sense! Added make fmt and updated the doc.

a7i
a7i reviewed Sep 30, 2022
View reviewed changes
Makefile
@@ -137,6 +140,12 @@ ifndef HAS_GOLANGCI
endif
./_output/bin/golangci-lint run

fmt:
ifndef HAS_GOFUMPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on adding it to the script used by verify-gofmt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually golangci-lint already verifies it. should we also add a secondary check anyway?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary. @damemi ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like make verify already runs lint, so we don't need a second check then. As long as there is a local way to verify that this has been updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also notice that this make fmt is to run gofumpt formatter on every **/*.go file. (excludes ./vendor by default)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damemi are you suggesting that we should remove make fmt since lint already runs this?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2022
@a7i
Copy link
Contributor

a7i commented Nov 1, 2022

@Dentrax sorry for the delay on this PR. would you please rebase so we can move forward on the review?

@Dentrax
run: gofumpt -w -extra .
99868a4 
Enable gofumpt in golangci

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@Dentrax
Copy link
Contributor Author

Dentrax commented Nov 7, 2022

Rebased.

damemi
damemi reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@a7i
Copy link
Contributor

a7i commented Nov 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit d997be5 into kubernetes-sigs:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i a7i left review comments

@damemi damemi damemi left review comments

Assignees

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dentrax @k8s-ci-robot @a7i @damemi