README: be more explicit about scope of the descheduler.alpha.kubernetes.io/evict annotation #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes.io/evict annotation
k8s-ci-robot
added
cncf-cla: yes
damemi
reviewed
Oct 17, 2022
| @@ -791,6 +791,9 @@ best effort pods are evicted before burstable and guaranteed pods. | |||
| * All types of pods with the annotation `descheduler.alpha.kubernetes.io/evict` are eligible for eviction. This | |||
| annotation is used to override checks which prevent eviction and users can select which pod is evicted. | |||
| Users should know how and if the pod will be recreated. | |||
| The annotation only affects internal descheduler checks. | |||
| The anti-disruption protection provided by the [/eviction](https://kubernetes.io/docs/concepts/scheduling-eviction/api-eviction/) | |||
There was a problem hiding this comment.
just checking do you mean to have / to denote it's a subresource?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA