correct JSON log format

[wakeful]

today I upgraded to 0.25.2 version and noticed that the json format is not working
after a quick scan of the code I noticed that factory is always nil.

some related problems #991 and #965

I'm sure there is a much more elegant solution to this problem.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: wakeful / name: AJ (1551242)

[k8s-ci-robot]

Welcome @wakeful!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @wakeful. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ingvagabund]

The last change in the formatting was performed in c9b0fbe. @wakeful would undoing the change help?

[wakeful]

@ingvagabund I believe so but then the external dep upgrade will also be rollback,

-
-			factory, _ := registry.LogRegistry.Get(s.Logging.Format)
+			var factory registry.LogFormatFactory
 			if factory == nil {
 				klog.ClearLogger()

looking at the above patch I suspect the underlying API has change and the code was just adjusted to compile
as this project is lacking tests around flags it went unnoticed.

personally I think we should fix it without rollback / revert, add test(s) and push out a patch version

[damemi]

Thank you for finding this @wakeful

personally I think we should fix it without rollback / revert, add test(s) and push out a patch version

+1

[damemi]

/ok-to-test

[ingvagabund]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damemi]

@ingvagabund wdyt about another patch release for this?

[ingvagabund]

@wakeful is releasing a new descheduler version paramount for your business? Or, can you build the descheduler image from the latest master:HEAD and run in meantime?

@damemi unless there's a strong need for it, I prefer to wait until more fixes are merged.

[wakeful]

hey @ingvagabund for now we are running a custom build from top of master :)