-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support explicitly specifying which CLI binaries to invoke #282
Comments
As a side note, it would also be useful to debug log which binaries are being used. |
/reopen |
@harshanarayana: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I missed taking care of a few items on the previous PR. Need to update a few more bits and then this can be closed. |
The e2e-framework offers packages to help spin up Kind clusters and install Helm charts. These packages wrap the
kind
andhelm
CLI tools. (There may be other wrapped CLI tools but I haven't encountered them yet.)The framework seems to look for these tools with hardcoded binary names (
kind
,helm
) in$PATH
. Ifkind
isn't available the framework attempts to install it usinggo install
. Ifhelm
isn't available the framework returns an error.In @crossplane our
Makefile
handles installation of tools like Kind and Helm, but it doesn't install them in$PATH
. We can probably hack around this when running the E2E tests (e.g. add a dir to$PATH
and symlink to the tools from that dir) but it would be ideal to be able to pass the path to the binaries as flags.The text was updated successfully, but these errors were encountered: