controller-runtime: enable ability to fetch controller runtime client

[harshanarayana]

What does this do ?

Enable the ability to fetch the reusable controller-runtime client via the e2e-framework infra.

Why is this required?

#146 (comment) Has a good explanation on the usability of this features.

Fixes #146

[k8s-ci-robot]

Hi @harshanarayana. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vladimirvivien]

Thanks for the prompt PR.
I left couple of comments.

[vladimirvivien]

I am not sure if this is needed. What I do think is needed is a way to inject an existing Controller Runtime client to be used be used with Resources:

func (r *Resources) SetCRClient(c cr.Client) {
  r.client = c
}

Or something like that

[harshanarayana]

@vladimirvivien THis might break a few things if we are not careful possibly ?

type Resources struct {
	config *rest.Config
	scheme *runtime.Scheme
	client cr.Client
	namespace string
}

If we are to override the Resources.client should we allow the same for Resources.config if so, how do we enforce that? Document it and hope everyone will read and keep that in mind ? Might get a bit messy is it not ?

[harshanarayana]

I think we should not let someone set the Resources.Client directly. Instead, use the klient/client.go method to create a new resource for custom config or use the GetControllerRuntimeClient function from the Resources to access the already existing client. That way, we can keep this clean.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[harshanarayana]

/remove-lifecycle stale

[vladimirvivien]

This looks good to me. Thanks @harshanarayana

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment