Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating example controller test to e2e-framework v0.5.0 and make it running #476

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Updating example controller test to e2e-framework v0.5.0 and make it running #476

merged 1 commit into from
Jan 16, 2025

Conversation

dmvolod
Copy link
Member

@dmvolod dmvolod commented Jan 6, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates e2e-framework inside the controller test example to the latest release version v0.5.0 and make it running, including additional diagnostics output in case of failure in separate steps, i.e. docker build or controller-gen run. Also small text typos are fixed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

"NONE"

Additional documentation e.g., Usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 6, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 6, 2025
cpanato
cpanato requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

some updates, thanks for doing this

examples/controller_tests/testdata/Dockerfile Outdated
@@ -13,7 +13,7 @@
# limitations under the License.

# Build the manager binary
FROM golang:1.21 as builder
FROM golang:1.22 AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can bump to 1.23

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed

examples/controller_tests/testdata/go.mod Outdated
@@ -1,77 +1,82 @@
module tutorial.kubebuilder.io/project

go 1.20
go 1.22.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to 1.23

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this, go version 1.22.3 came from the e2e-framework v0.5.0 in go.mod automatically and aligned with all components? Is there any plans to bump golang verison in project go.mod soon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can do in a follow up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@dmvolod dmvolod force-pushed the update-example-controller-test-to-v0.5.0 branch from 8b65b46 to c40ece1 Compare January 6, 2025 17:56
@vladimirvivien
Copy link
Contributor

@dmvolod if you fix the conflicts, this should be ready to go.
(Thanks @cpanato for the first look)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@dmvolod dmvolod force-pushed the update-example-controller-test-to-v0.5.0 branch from c40ece1 to cef945c Compare January 15, 2025 14:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@dmvolod
Copy link
Member Author

dmvolod commented Jan 15, 2025

@dmvolod if you fix the conflicts, this should be ready to go. (Thanks @cpanato for the first look)

Thanks for review, @vladimirvivien
Fixed

cpanato
cpanato approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dmvolod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit a5b5eb8 into kubernetes-sigs:main Jan 16, 2025
4 checks passed
@dmvolod dmvolod mentioned this pull request Jan 24, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

@vladimirvivien vladimirvivien Awaiting requested review from vladimirvivien

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmvolod @k8s-ci-robot @vladimirvivien @cpanato