Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.0 don't support arg --oci-zone-scope= #4151

Closed
RuanCarvalh opened this issue Jan 3, 2024 · 12 comments
Closed

v0.14.0 don't support arg --oci-zone-scope= #4151

RuanCarvalh opened this issue Jan 3, 2024 · 12 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@RuanCarvalh
Copy link

What happened:

the argument "--oci-zone-scope=" is not published in version v0.14.0 in the documentation for OCI, its use is recommended for this version: https://github.com/kubernetes-sigs/external-dns/blob/ master/docs/tutorials/oracle.md

However, we don't have it created: https://github.com/kubernetes-sigs/external-dns/blob/raffo/kustomize-v0.14.0/provider/oci/oci_test.go

When trying to use it we received the invalid file error

What you expected to happen:

In the master branch it is created: https://github.com/kubernetes-sigs/external-dns/blob/master/provider/oci/oci_test.go
I think there was some merge missing

How to reproduce it (as minimally and precisely as possible):
Deploy external DNS on v0.14.0 using --oci-zone-scope=GLOBAL or --oci-zone-scope=PRIVATE

Environment:

  • External-DNS version 0.14.0
  • DNS provider: OCI
@RuanCarvalh RuanCarvalh added the kind/bug Categorizes issue or PR as related to a bug. label Jan 3, 2024
@dongjiang1989
Copy link
Contributor

This feature is in the main branch, not in the v0.14.0 tag.

@RuanCarvalh
Copy link
Author

This feature is in the main branch, not in the v0.14.0 tag.

Yes, I understand, but in the documentation it is recommended to use version 0.14.0 to use this feature, but it is not available, would you know which version I should use to have the feature?

@wellwanger
Copy link

Hi @RuanCarvalh! in my research this feature was merged to master recently by PR #3995 so I understand that it will available in next release of the project.

@benarnold42
Copy link

It looks like the only thing missing is the next release. Any idea when this might happen?

@omidizadkhasti
Copy link

Hi @wellwanger, is there any update when this features will available. and is there any workaround to use this feature in our environment (by pull mater and build the image)?

@wellwanger
Copy link

Hi @omidizadkhasti, I am not a member of this project so I don`t have info about next release date. What I can say is that as a temporary solution you could use a fork of dns external available at project Verrazzano (Open source project curated by Oracle) which already has this feature available. https://github.com/verrazzano

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 4, 2024
@wizbe97
Copy link

wizbe97 commented Jul 10, 2024

it is worth noting that for OCI, the --oci-zone-scope flag does not actually work, in the 0.14.2 image version.

I have to set it to --oci-zone-scope= rather to work in my zones, setting --oci-zone-scope=PRIVATE does not create any records

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@wellwanger
Copy link

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants