-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart Webhook Provider port mismatch #4764
Comments
The documentation explain the purpose of those two ports:
And
For security reason, only this metrics port is exposed in the Chart. It allows API port to listen only for localhost, so only external-dns can call it. The metrics port is not sensitive, so it can listen more widely without any risk. external-dns/charts/external-dns/templates/deployment.yaml Lines 159 to 162 in 45257fb
The probes are entirely configurable: external-dns/charts/external-dns/values.yaml Lines 252 to 260 in 45257fb
So I am not sure to get your issue. There is no mismatch, it's done on purpose, for security reason. |
Thanks for the detailed explanation, that makes sense! I raised an issue with the webhook provider I use. |
What happened:
External-dns uses a hardcoded port (8888) for Webhook providers:
external-dns/main.go
Line 371 in b336c52
However, the Helm chart defines a liveness probe for the webhook provider on port 8080:
external-dns/charts/external-dns/templates/deployment.yaml
Line 162 in b336c52
This inconsistency results in a CrashLoopBackOff, as the health check is looking for the service on port 8080, while the actual service runs on port 8888.
What you expected to happen:
Both ports are hardcoded and should be aligned to avoid this issue.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
external-dns --version
): external-dns-helm-chart-1.15.0The text was updated successfully, but these errors were encountered: