-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider GoDaddy fix domain update #3427
Conversation
Welcome @nefelim4ag! |
Gentle ping: |
/ok-to-test |
|
fix: godaddy.go - gofmt fix: linter errors
@szuecs done, sorry for the long response |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Nefelim4ag, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
(I'm not Go dev so sorry if I do it too wrong)
Fix handling of second-level domains like
example.com
Handle it in an obvious way because the old check was not supposed for that.
GoDaddy API used in the right way: https://developer.godaddy.com/doc/endpoint/domains
Check changes and only apply what actually changed.
Use PUT for record replacement (API doesn't allow partial updates or deletes).
Additionally:
Discard
message, because as an end-user I several times got baldpublic.ecr.aws/xflow-ltd/external-dns:0.13.5
Old log, with lost of TXT records and broken dns
New log:
Fixes #2467
Checklist