Follow CLA doc to kubernetes/community #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Thanks @spiffxp! |
ffledgling
pushed a commit
to ffledgling/external-dns
that referenced
this pull request
Jan 18, 2018
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
* Update error message when upgrading plugin that isn't in the manifest Also remove line from run-tests.sh for file that was deleted in kubernetes-sigs/external-dns@e37ee1d#diff-d78b6f30225cdc811adfe8d4e7c9fd34 * Update messaging when installing non-existent plugin * Skip installing plugins that are already installed * Use os.IsNotExist * Code review changes emove check on installed plugin and use %q and errors.New * Use errors.Errorf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: kubernetes/kubernetes#57689