-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to aws-sdk-go-v2 #4640
Migrate to aws-sdk-go-v2 #4640
Conversation
0406eb8
to
4dc5c92
Compare
Thanks for this @mjlshen. It's amazing. |
Thanks @mloiseleur! I needed to rebase to resolve conflicts in go.mod - I'm happy to help test this on AWS. I'll plan on going through https://kubernetes-sigs.github.io/external-dns/v0.14.2/tutorials/aws-sd/ and https://kubernetes-sigs.github.io/external-dns/v0.14.2/tutorials/aws/ to make sure these still work and will report back with how it went. If there's anything else I can help with please feel free to let me know as well.
|
@szuecs / @mloiseleur I have (finally :D) validated my code in AWS by:
So I'm confident that it works! Is there anything else I can help test or demonstrate? |
Signed-off-by: Michael Shen <mishen@umich.edu>
Signed-off-by: Michael Shen <mishen@umich.edu>
Signed-off-by: Michael Shen <mishen@umich.edu>
Signed-off-by: Michael Shen <mishen@umich.edu>
bf9d2a0
to
0de6f8a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mloiseleur when you have time, it would be great to have a re-review on this one. Thanks! |
/lgtm |
Description
This PR migrates the codebase to aws-sdk-go-v2 by migrating these three main components:
Which then allowed me to:
My commits are all self-contained to align with those 4 steps, so I'd be happy to split this PR up if that would be preferred.
Fixes #4637
Checklist