-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare): support cloudflare region #4646
feat(cloudflare): support cloudflare region #4646
Conversation
Hi @AndrewCharlesHay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@johngmyers or @mloiseleur how do I run tests for this? How does the PR look? |
/ok-to-test |
@Raffo & @johngmyers I fixed the tests! Let me know if everything looks good |
@Raffo or @johngmyers Any update? |
/retitle feat(cloudflare): support cloudflare region |
It looks better, now 👍 . Would you please rebase and add some documentation on how to use it ? |
🇪🇺 I added your region as the host for the example @mloiseleur 😉 How does the updated documentation look to you? |
/lgtm |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you both for your support! Do you have an idea on when the next release will be? |
@AndrewCharlesHay I expect to do a release in early December. |
Description
I am trying to add the option to pass in Cloudflare region. This is a work in progress. This definitely doesn't work yet, just showing what I was thinking if someone wants to point me in the right direction
Fixes #4644
Checklist