Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare): support cloudflare region #4646

Merged

Conversation

AndrewCharlesHay
Copy link
Contributor

@AndrewCharlesHay AndrewCharlesHay commented Jul 31, 2024

Description

I am trying to add the option to pass in Cloudflare region. This is a work in progress. This definitely doesn't work yet, just showing what I was thinking if someone wants to point me in the right direction

Fixes #4644

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AndrewCharlesHay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
@AndrewCharlesHay AndrewCharlesHay changed the title feat: add cloudflare host name Draft: add cloudflare host name Jul 31, 2024
@AndrewCharlesHay AndrewCharlesHay changed the title Draft: add cloudflare host name Feature: add cloudflare host name Aug 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
@AndrewCharlesHay
Copy link
Contributor Author

@johngmyers or @mloiseleur how do I run tests for this? How does the PR look?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
provider/cloudflare/cloudflare.go Outdated Show resolved Hide resolved
provider/cloudflare/cloudflare_test.go Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

/ok-to-test
Please remove the content of devcontainer.json of this PR. You can submit it in an other PR.

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 14, 2024
@AndrewCharlesHay
Copy link
Contributor Author

AndrewCharlesHay commented Oct 11, 2024

@Raffo & @johngmyers I fixed the tests! Let me know if everything looks good

@AndrewCharlesHay
Copy link
Contributor Author

@Raffo or @johngmyers Any update?

provider/cloudflare/cloudflare.go Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

/retitle feat(cloudflare): support cloudflare region

@k8s-ci-robot k8s-ci-robot changed the title Feature: add cloudflare host name feat(cloudflare): support cloudflare region Nov 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2024
@mloiseleur
Copy link
Contributor

mloiseleur commented Nov 1, 2024

It looks better, now 👍 .

Would you please rebase and add some documentation on how to use it ?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2024
@AndrewCharlesHay
Copy link
Contributor Author

AndrewCharlesHay commented Nov 1, 2024

🇪🇺 I added your region as the host for the example @mloiseleur 😉 How does the updated documentation look to you?

@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2024
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2024
@mloiseleur
Copy link
Contributor

/lgtm
/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2024
@Raffo
Copy link
Contributor

Raffo commented Nov 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit ea6d44b into kubernetes-sigs:master Nov 4, 2024
13 checks passed
@AndrewCharlesHay AndrewCharlesHay deleted the cloudflare/region branch November 4, 2024 17:29
@AndrewCharlesHay
Copy link
Contributor Author

Thank you both for your support! Do you have an idea on when the next release will be?

@Raffo
Copy link
Contributor

Raffo commented Nov 12, 2024

@AndrewCharlesHay I expect to do a release in early December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specify region for Cloudflare DNS record
4 participants