Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple provider specific annotations of same type #4734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roehrijn
Copy link
Contributor

@roehrijn roehrijn commented Sep 10, 2024

Description

External DNS already supports exposing a single K8s service behind multiple hostnames by using the external-dns.alpha.kubernetes.io/hostname annotation with a comma-seperated list of hostnames in its value. One would do this for example for making a service availible with a technical, static hostname and a DNS load-balancer, like Route53 can act as, at the same time.
However, when defining additonal annotations on the service, e.g. external-dns.alpha.kubernetes.io/aws-weight this always applies to all the hostnames of the service. This makes it impossible to define different weights for different hostnames on the same service. At the same time it is not possible that an annotation only applies to a single one and not all the hostnames of a service.

This PR implements a solution to make exactly the described configuration possible by introducing a kind of "string map" notation in the annotations' values.

For example:

external-dns.alpha.kubernetes.io/hostname: my.foo.app, my.foo.internal
external-dns.alpha.kubernetes.io/aws-weight: my.foo.app=100

would define the two hostname my.foo.app and my.foo.internal, whereas a load balancing weight is only set for my.foo.app.

Checklist

  • Unit tests updated
  • End user documentation updated

Jan Roehrich jan.roehrich@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from szuecs September 10, 2024 13:45
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @roehrijn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2024
@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2024
@mloiseleur
Copy link
Contributor

Thanks. It looks good, implementation is light and it's documented 👍
/lgtm
/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2024
@mloiseleur mloiseleur removed their assignment Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants