-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pihole): gracefully avoid invalid request with wildcard #4904
Conversation
Welcome @MicahBird! |
Hi @MicahBird. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @MicahBird 👍 |
Test added! |
/ok-to-test |
/retitle fix(pihole): gracefully avoid invalid request with wildcard |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
Apologies for the failed tests, this is my first time working with a Go project of this size, hopefully everything should be good to go now! 😅 |
No problem. Thanks for taking the time to clean it 👍 |
Fixes #4621 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR is simply following in the footsteps of @alex4108's work and utilizes SoftError rather than return nil.
Fixes #4622
Checklist