Skip to content

update guides docs to fix miss guide #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

update guides docs to fix miss guide #1532

merged 2 commits into from
Sep 4, 2025

Conversation

Frapschen
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1530

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 4, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 4, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 24be9d5
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68b969ad1592ad0008938d13
😎 Deploy Preview https://deploy-preview-1532--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Frapschen!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Frapschen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2025
Frapschen
Frapschen commented Sep 4, 2025
View reviewed changes
site-src/guides/index.md Outdated
Depending on the type of model server you have deployed, you must update the model field in the request body accordingly:
- vLLM Simulator Model Server: `food-review-1`
- CPU-Based Model Server: `food-review-0` or `food-review-1`
- GPU-Based Model Server: TODO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find the mode value for the GPU one. Please help me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding an answer so you'll learn more about how it's being set -
you can find it here:

gateway-api-inference-extension/config/manifests/vllm/gpu-deployment.yaml

Line 257 in c90106c

- id: food-review-1

nirrozenbaum
nirrozenbaum reviewed Sep 4, 2025
View reviewed changes
site-src/guides/index.md Outdated
Comment on lines 300 to 304
Depending on the type of model server you have deployed, you must update the model field in the request body accordingly:
- vLLM Simulator Model Server: `food-review-1`
- CPU-Based Model Server: `food-review-0` or `food-review-1`
- GPU-Based Model Server: TODO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed. food-review-1 should work for all.

@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

@nirrozenbaum
Copy link
Contributor

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Frapschen, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7fcce71 into kubernetes-sigs:main Sep 4, 2025
9 checks passed
@Frapschen Frapschen deleted the update-guide-docs branch September 4, 2025 11:04
@nirrozenbaum nirrozenbaum mentioned this pull request Sep 4, 2025
Closed
@Frapschen Frapschen mentioned this pull request Sep 25, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

Assignees

@nirrozenbaum nirrozenbaum

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InferencePool "vllm-llama3-8b-instruct" not found
3 participants
@Frapschen @k8s-ci-robot @nirrozenbaum