Skip to content

Conversation

Frapschen
Copy link
Contributor

What type of PR is this?
/kind test

What this PR does / why we need it:

After this enhancement, make test-unit will finally print:

...
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:249:                                                               TargetPortNumber                                0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:254:                                                               ExtensionRef                                    0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:260:                                                               ObjRef                                          0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/generator/main.go:35:                                                                           main                                            0.0%
total:                                                                                                                                          (statements)                                    60.4%

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@Frapschen: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:

After this enhancement, make test-unit will finally print:

...
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:249:                                                               TargetPortNumber                                0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:254:                                                               ExtensionRef                                    0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/testing/wrappers.go:260:                                                               ObjRef                                          0.0%
sigs.k8s.io/gateway-api-inference-extension/pkg/generator/main.go:35:                                                                           main                                            0.0%
total:                                                                                                                                          (statements)                                    60.4%

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Sep 18, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 00f5965
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68cbd3dd187a8e000842bf33
😎 Deploy Preview https://deploy-preview-1614--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Frapschen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 19, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Frapschen, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit f1e4bd3 into kubernetes-sigs:main Sep 19, 2025
11 checks passed
@Frapschen Frapschen deleted the impore-make-test branch September 22, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants