Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
  • Loading branch information
zhaohuabing committed Sep 5, 2023
1 parent d7beeee commit 1e547eb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion apis/v1alpha2/policy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ type PolicyTargetReference struct {
// Policy resource, refer to the policy attachment documentation for Gateway API.
//
// Note: This should be used for direct policy attachment only.
// <gateway:experimental>
type DirectPolicyTargetReference struct {
PolicyTargetReference `json:",inline"`

Expand Down
8 changes: 4 additions & 4 deletions geps/gep-713.md
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,8 @@ spec:
sectionName: bar
```

This would require adding a `Name` field to those sub-resources that currently lack a name. For example,
a `Name` field could be added to the `RouteRule` object:
This would require adding a `name` field to those sub-resources that currently lack a name. For example,
a `name` field could be added to the `RouteRule` object:
```go
type RouteRule struct {
// Name is the name of the Route rule. If more than one Route Rule is
Expand All @@ -1337,8 +1337,8 @@ type RouteRule struct {
If a `sectionName` is specified, but does not exist on the targeted object, the Policy must fail to attach,
and the policy implementation should record a `resolvedRefs` or similar Condition in the Policy's status.

When multiple Policies of the same type target the same object, one with a `SectionName` specified, and one without,
the one with a `SectionName` is more specific, and so will have all its settings apply. The less-specific Policy will
When multiple Policies of the same type target the same object, one with a `sectionName` specified, and one without,
the one with a `sectionName` is more specific, and so will have all its settings apply. The less-specific Policy will
not attach to the target.

Note that the `sectionName` is currently intended to be used only for Direct Policy Attachment. Inherited Policies
Expand Down

0 comments on commit 1e547eb

Please sign in to comment.