Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate At Least One of GRPCRoute.Rules.Matches.{Method,Service} is Supplied #1098

Closed
gnossen opened this issue Apr 7, 2022 · 9 comments · Fixed by #1490
Closed

Validate At Least One of GRPCRoute.Rules.Matches.{Method,Service} is Supplied #1098

gnossen opened this issue Apr 7, 2022 · 9 comments · Fixed by #1490
Assignees
@gyohuangxin
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6.0

Comments

@gnossen
Copy link
Contributor

gnossen commented Apr 7, 2022

As a result of this exchange, it was decided to require at least one of the fields Service and Method of GRPCMethodMatch to be specified. This is not currently possible via JSON-schema validations, so enabling this will require changes to the validating webhook.
@gnossen gnossen added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 7, 2022
@gnossen gnossen mentioned this issue Apr 7, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2022
@youngnick
Copy link
Contributor

/remove-lifecycle stale

Waiting for the inital cut of GRPCRoute to be implemented in #1115.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2022
@robscott
Copy link
Member

Looks like we missed this. Adding to v0.6.0 milestone.

/help

@k8s-ci-robot
Copy link
Contributor

@robscott:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Looks like we missed this. Adding to v0.6.0 milestone.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 13, 2022
@robscott
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2022
@robscott robscott added this to the v0.6.0 milestone Oct 13, 2022
@gyohuangxin
Copy link
Member

I'd like to implement it.
/assign

@robscott
Copy link
Member

@gyohuangxin are you still able to work on this? Anything we can help with?

@gyohuangxin
Copy link
Member

@robscott Yes, sorry for being busy with other things. I'll work on this these days.

@gyohuangxin gyohuangxin mentioned this issue Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyohuangxin gyohuangxin

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.6.0
6 participants
@robscott @gnossen @youngnick @k8s-ci-robot @gyohuangxin @k8s-triage-robot