-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported feature warning mechanism #1804
Comments
/assign @LiorLieberman |
Hey @LiorLieberman 👋 just checking in. Let us know if you need any help moving this forward, have any questions, e.t.c. |
As discussed, I opened a discussion item about it #2108. Will try to follow up with a GEP OR expanding the conformance profiles GEP next week. The first iteration would be enhancing the API, we will follow up with the webhook work once we have a few implementations already reporting features in the GWC status. |
GatewayClassStatus enhancement to include the features is covered by #2163 and is implemented in #2461. What do you want to do with this issue? I think we should wait until we see more implementations of the SupportedFeatures in status and then revisit the warning mechanism. It may also fit to be a gwctl command |
I don't want to see it become only a |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/area gwctl |
/remove-lifecycle rotten |
What would you like to be added:
A mechanism by which implementations can clearly indicate when they don't support a particular feature and raise that to end-users who try to use the feature.
Why this is needed:
Presently if an end-user tries to use a feature on any given implementation (without having first thoroughly read the docs) it may be very unclear why that feature doesn't work if the implementation doesn't support it. As an improvement to UX it would be nice if implementations can implicate the features they do or do not support so that this can bubble up to the end-users.
Additional Notes:
I'm aware of two proposed ideas for the implementation of this historically:
GatewayClass
to indicate feature support, therefore enabling the validating webhook to make enforcements before the offending configurations can even be storedWe should consider those and any other options and make a small GEP for this to make sure we have consensus amongst stakeholders.
This relates slightly to #1709 and we should consider where there may be cross-pollination.
The text was updated successfully, but these errors were encountered: