Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec unclear for scheme redirects in HTTPRoute #1909

Closed
robscott opened this issue Apr 4, 2023 · 4 comments · Fixed by #1880
Closed

Spec unclear for scheme redirects in HTTPRoute #1909

robscott opened this issue Apr 4, 2023 · 4 comments · Fixed by #1880
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@robscott
Copy link
Member

robscott commented Apr 4, 2023

What happened:
As feedback in #1908, @howardjohn pointed out that it's currently unclear how scheme and port interact in the redirect filter. Two examples below:

  1. If an incoming request is to http://example.com (on port 80), and the redirect simply requests "HTTPS" scheme without specifying port, what should the implementation do?

A) https://example.com
B) https://example.com:80

  1. Similarly if an incoming request is to http://example.com:80, and the redirect simply requests "HTTPS" scheme without specifying port, what should the implementation do?

A) https://example.com
B) https://example.com:80

  1. Finally, if an incoming request is to http://example.com:8080, and the redirect simply requests "HTTPS" scheme without specifying port, what should the implementation do?

A) https://example.com
B) https://example.com:8080

What you expected to happen:
The spec should tell implementations how to treat these scenarios.

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Apr 4, 2023
@shaneutt shaneutt added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 5, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Apr 5, 2023
@shaneutt
Copy link
Member

shaneutt commented Apr 5, 2023

It would be nice if we could get this sorted out before GA, since HTTPRoute will be the first GA route.

Could use some help from a community member to bring this up in discussions, tease this out and then get a patch to the documentation.

/help

@k8s-ci-robot
Copy link
Contributor

@shaneutt:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

It would be nice if we could get this sorted out before GA, since HTTPRoute will be the first GA route.

Could use some help from a community member to bring this up in discussions, tease this out and then get a patch to the documentation.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 5, 2023
@gauravkghildiyal
Copy link
Member

I've already been involved with this so lets take it all the way.

/assign

@shaneutt shaneutt removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 6, 2023
@shaneutt shaneutt moved this from Backlog to In Progress in Gateway API: The Road to GA Apr 6, 2023
@gauravkghildiyal
Copy link
Member

I've put my thoughts in this doc. Will try to bring this up in some Gateway API meeting -- if time permits :)

@robscott robscott modified the milestones: v1.0.0, v0.7.0 May 5, 2023
@robscott robscott added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants