-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to include the certificate/s in the CapturedResponse of the conformance test #3020
Comments
/assign @snehachhabria |
@youngnick: GitHub didn't allow me to assign the following users: snehachhabria. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @snehachhabria |
Per the discussion on this issue on the meeting, currently there are no tests in the conformance that are asserting on this, however exposing this will allow the extension of tests to make these assertions as well in the future. If an unexpected cert is provided there will be a TLS connection error and there is no need to validate the cert in this scenario but for success scenarios additional validation will help assert the cert details. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Request to include the certificate/s in the CapturedResponse of the conformance test:
To verify the certificate served by the listener/service:
During our testing we found that roundtripper.CapturedResponse does not have a certificates field similar to http.Response(https://github.com/golang/go/blob/master/src/crypto/tls/common.go#L265). It would come in handy for testing as we currently have a wrapper for the same.
or If there is any other way in which this is already done, It would be great to know about it
The text was updated successfully, but these errors were encountered: