Renaming ReferencePolicy to ReferenceGrant #1179
Conversation
k8s-ci-robot
added
kind/api-change
k8s-ci-robot
added
the
approved
|
Adding a temporary hold so everyone has a chance to add feedback, will remove this sometime tomorrow. /cc @shaneutt @youngnick @howardjohn @mikemorris |
k8s-ci-robot
added
the
do-not-merge/hold
|
@robscott: GitHub didn't allow me to request PR reviews from the following users: mikemorris, howardjohn. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like this was a straightforward search-and-replace, I agree with the ReferenceGrant name, and this LGTM. /lgtm |
k8s-ci-robot
added
the
lgtm
|
@mikemorris: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikemorris, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
robscott
force-pushed
the
rename-reference-policy
branch
from
de99000 to
d1370a7
Compare
k8s-ci-robot
removed
the
lgtm
|
Thanks for the reviews @mikemorris, @shaneutt, and @youngnick! Updated to address feedback, PTAL. |
|
Think we've got enough consensus around this, will let next LGTM merge this in. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
These were missed in kubernetes-sigs#1179
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> Rename files to reflect ReferencePolicy -> ReferenceGrant These were missed in kubernetes-sigs#1179 feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> change package Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
* feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> * feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> * recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> * change package Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> * recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> Rename files to reflect ReferencePolicy -> ReferenceGrant These were missed in #1179 feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> change package Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Renames ReferencePolicy to ReferenceGrant. Renaming this resource was originally suggested in the community meeting on Jan 24, and then revisited in several additional meetings. I ran a poll in March at which point "ReferenceGrant" was the most popular name. I think this has largely been accepted as something that will happen, but no one has had the time to actually make the change. With v0.5.0 around the corner, it seems like we should try to fit this change in if possible.
Getting this change in would also help with a KEP that is relying on this resource and is concerned that a rename at a later point could result in confusion/instability.
Does this PR introduce a user-facing change?: