-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Attached condition with Accepted in HTTPRoute docs #1382
replace Attached condition with Accepted in HTTPRoute docs #1382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So from what I can tell, this appears to be right: we've had this wrong for some time as the Accepted
condition exists for HTTPRoute
but not Attached
(which is only a Gateway
listener condition elsewhere). Approved, but I would like another maintainer to just double check me and give the LGTM because I can't shake the feeling like I might be missing something 🤔
This change is one hundred percent correct as per the current spec, but I'm currently working on a status rewrite which proposes we move to |
This content likely needs to be revisited now that #1383 has merged. |
So this was just trying to fix a bug in the v0.5.0 spec/docs, but I guess at this point it's probably missed the boat for inclusion in v0.5.1? If so, and the broader v0.6.0 conditions changes will cover this, then we can just close this one out and live with the v0.5.x docs bug. |
The HTTPRoute docs have several references to an "Attached" condition, however this condition does not exist for routes. Replaces these references with the appropriate "Accepted" condition. Signed-off-by: Steve Kriss <krisss@vmware.com>
2e832a5
to
2357da5
Compare
Rebased in case we want to include it in v0.5.1, if not, and will be covered by larger v0.6 changes, feel free to close. |
Thanks @skriss! If you follow up with a cherry-pick PR into release-0.5, I'll add it to the v0.5.1 changelog. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt, skriss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(release-0.5 cherrypick of #1382) replace Attached condition with Accepted in HTTPRoute docs
The HTTPRoute docs have several references to
an "Attached" condition, however this condition
does not exist for routes. Replaces these
references with the appropriate "Accepted"
condition.
Signed-off-by: Steve Kriss krisss@vmware.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The HTTPRoute docs have several references to
an "Attached" condition, however this condition
does not exist for routes. Replaces these
references with the appropriate "Accepted"
condition.
See https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.RouteConditionType for the list of valid Route condition types and reasons.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: