Graduating GEP-726 (Path Redirects and Rewrites) to standard #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
5 tasks
youngnick
reviewed
Mar 24, 2023
k8s-ci-robot
added
the
lgtm
shaneutt
requested changes
Mar 28, 2023
robscott
force-pushed
the
gep-726-standard
branch
from
2e08417 to
fa2bb5e
Compare
k8s-ci-robot
removed
the
lgtm
|
Good catch, thanks @shaneutt! Missed that the first time but removed now. Removing hold since I think we've had enough approvals, next LGTM should merge this. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This GEP has met the criteria for graduating to standard channel, as documented in #726 (comment). This PR updates the GEP, documentation, and API types to reflect that.
Which issue(s) this PR fixes:
Fixes #726
Does this PR introduce a user-facing change?:
/hold for consensus