Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduating GEP-1323: Response Header Modifier to standard #1905

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

robscott
Copy link
Member

@robscott robscott commented Apr 3, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
The graduates GEP-1323: Response Header Modifier to standard.

Which issue(s) this PR fixes:
Fixes #1875

GEP-1323: Response Header Modifier has graduated to standard

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from bowei and youngnick April 3, 2023 17:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2023
@robscott
Copy link
Member Author

robscott commented Apr 3, 2023

Would like multiple LGTMs before merging since this is graduating a feature, adding a hold.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2023
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@robscott
Copy link
Member Author

robscott commented Apr 5, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 26ce3a3 into kubernetes-sigs:main Apr 5, 2023
@shaneutt shaneutt added this to the v0.7.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Graduate GEP-1323 (ResponseHeaderModifier) to Standard Channel
5 participants