Fixes for mesh conformance tests #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
k8s-ci-robot
added
kind/test
area/conformance
area/mesh
|
Thanks @keithmattix! These changes LGTM and are probably worth merging prior to the v0.7.0 release on Monday. I don't want to make that call on my own so will defer to @shaneutt or @youngnick. /lgtm |
k8s-ci-robot
added
the
lgtm
howardjohn
approved these changes
May 12, 2023
Xunzhuo
approved these changes
May 13, 2023
shaneutt
approved these changes
May 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, keithmattix, shaneutt, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
/area conformance
/area mesh
What this PR does / why we need it:
Make mesh conformance tests more reliable and fix path matching bug. Split from #44894 since it includes new conformance tests
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: