Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: Fixes to port and scheme redirect tests #2039

Conversation

sunjayBhatia
Copy link
Member

What type of PR is this?
/kind bug
/kind cleanup
/area conformance

What this PR does / why we need it:
Tests expected redirect host was not consistent with request host, were sending HTTPS requests send inconsistent SNI and Host, cert presented by Gateway did not have the correct SANs.

Which issue(s) this PR fixes:
Fixes #2038

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance labels May 18, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2023
Tests expected redirect host was not consistent with request host,
were sending HTTPS requests send inconsistent SNI and Host, cert
presented by Gateway did not have the correct SANs.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia force-pushed the redirect-port-scheme-https-fixes branch from a4df88f to 8e54974 Compare May 18, 2023 22:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 18, 2023
@shaneutt shaneutt added this to the v0.7.1 milestone May 19, 2023
@robscott
Copy link
Member

Thanks @sunjayBhatia! This LGTM but would like someone else to review.

/cc @arkodg @mlavacca
/approve
/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

Thanks @sunjayBhatia! This LGTM but would like someone else to review.

/cc @arkodg @mlavacca
/approve
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from arkodg and mlavacca May 19, 2023 16:41
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-infra-cherrypick-robot
Copy link
Contributor

@robscott: new pull request created: #2042

In response to this:

Thanks @sunjayBhatia! This LGTM but would like someone else to review.

/cc @arkodg @mlavacca
/approve
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunjayBhatia sunjayBhatia deleted the redirect-port-scheme-https-fixes branch May 19, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

conformance: HTTPS Redirect tests make requests with inconsistent SNI/Host
5 participants