-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance: Fixes to port and scheme redirect tests #2039
conformance: Fixes to port and scheme redirect tests #2039
Conversation
Tests expected redirect host was not consistent with request host, were sending HTTPS requests send inconsistent SNI and Host, cert presented by Gateway did not have the correct SANs. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
a4df88f
to
8e54974
Compare
Thanks @sunjayBhatia! This LGTM but would like someone else to review. |
@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@robscott: new pull request created: #2042 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/kind cleanup
/area conformance
What this PR does / why we need it:
Tests expected redirect host was not consistent with request host, were sending HTTPS requests send inconsistent SNI and Host, cert presented by Gateway did not have the correct SANs.
Which issue(s) this PR fixes:
Fixes #2038
Does this PR introduce a user-facing change?: