httproute: pluralize hostname and allow for wildcards #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/XL
hbagdi
force-pushed
the
pluralize-hostname
branch
from
5459ca2 to
26066a3
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
While this PR has two different changes, I opened this up as one. Let me know if I should separate this out. This PR also introduces some inconsistencies in how "wildcard" or "domain" (@jpeach :D) matching is defined at the listener level vs the HTTPRoute level. |
k8s-ci-robot
added
the
needs-rebase
robscott
reviewed
Jun 17, 2020
api/v1alpha1/httproute_types.go
Outdated
| } | ||
|
|
||
| // HTTPRouteHost is the configuration for a given host. | ||
| // HTTPRouteHost is the configuration for a given host(s). |
There was a problem hiding this comment.
Suggested change
| // HTTPRouteHost is the configuration for a given host(s). | |
| // HTTPRouteHost is the configuration for a given set of hosts. |
api/v1alpha1/httproute_types.go
Outdated
| // HTTPRoute rules. If the host is unspecified, traffic is routed | ||
| // based on the HTTPRouteRules. | ||
| // | ||
| // Host can be "precise" which is a domain name without the terminating |
There was a problem hiding this comment.
Suggested change
| // Host can be "precise" which is a domain name without the terminating | |
| // Hostnames can be "precise" which is a domain name without the terminating |
api/v1alpha1/httproute_types.go
Outdated
| // HTTPRoute with hostname example.com or bar.example.com will not match. | ||
| // If Hostname is unspecified, the Gateway routes all traffic based on | ||
| // the specified rules. | ||
| // Incoming requests are matched against the host before the |
There was a problem hiding this comment.
Suggested change
| // Incoming requests are matched against the host before the | |
| // Incoming requests are matched against the hosts before the |
|
looks like this is easy to fix and get merged /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, hbagdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This commit bundles two changes: - pluralizes hostnames to define the same route - allows for wildcards in the left-most label (same as Ingress V1)
hbagdi
force-pushed
the
pluralize-hostname
branch
from
26066a3 to
6886aff
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@robscott I've incorporated your feedback. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bundles two changes:
Fix #80