-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing concept of resource-level support levels #2323
Removing concept of resource-level support levels #2323
Conversation
03a9ee8
to
1f20d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to remove support levels at the resource level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
1f20d6e
to
8113fe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the comments
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind cleanup
/kind documentation
/area conformance
What this PR does / why we need it:
The concept of conformance levels has gotten rather confusing as we've added both new features and resources. Some resources (GRPCRoute and ReferenceGrant) had conformance levels defined while the rest did not. This does some refactoring to try to make our documentation and lists of conformance features more consistent. This gets us to a point where:
As a result, the most notable change is that StandardCoreFeatures has been split into two: GatewayCoreFeatures and ReferenceGrantCoreFeatures, this more clearly matches the rest of our feature set. Hopefully this makes sense, but definitely let me know if this is just more confusing.
Does this PR introduce a user-facing change?:
/hold
/cc @LiorLieberman @mlavacca @shaneutt