Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing concept of resource-level support levels #2323

Merged

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup
/kind documentation
/area conformance

What this PR does / why we need it:
The concept of conformance levels has gotten rather confusing as we've added both new features and resources. Some resources (GRPCRoute and ReferenceGrant) had conformance levels defined while the rest did not. This does some refactoring to try to make our documentation and lists of conformance features more consistent. This gets us to a point where:

  1. Resources don't have support levels, implementations can choose to support whichever set of resources they want
  2. Claiming the Support_Resource_ feature when running conformance tests means that you support the resource and all the core features it contains

As a result, the most notable change is that StandardCoreFeatures has been split into two: GatewayCoreFeatures and ReferenceGrantCoreFeatures, this more clearly matches the rest of our feature set. Hopefully this makes sense, but definitely let me know if this is just more confusing.

Does this PR introduce a user-facing change?:

Conformance Profiles: Some sets of features have been renamed to more closely match the resource they correspond to.

/hold
/cc @LiorLieberman @mlavacca @shaneutt

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mlavacca August 18, 2023 17:23
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from shaneutt August 18, 2023 17:23
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@robscott robscott force-pushed the remove-resource-support-levels branch from 03a9ee8 to 1f20d6e Compare August 18, 2023 17:30
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to remove support levels at the resource level.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@robscott robscott force-pushed the remove-resource-support-levels branch from 1f20d6e to 8113fe0 Compare August 21, 2023 20:39
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the comments
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member Author

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants