Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Conformance IPv6 fix #2340

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Mesh Conformance IPv6 fix #2340

merged 1 commit into from
Aug 23, 2023

Conversation

keithmattix
Copy link
Contributor

This builds on #2024 by applying it to the mesh conformance host logic as well

@keithmattix
More IPv6 fixes
765116f 
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@keithmattix keithmattix mentioned this pull request Aug 22, 2023
Merged
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 22, 2023
@shaneutt
Copy link
Member

/cc @kflynn @howardjohn @michaelbeaumont

@keithmattix
Copy link
Contributor Author

@shaneutt @michaelbeaumont @kflynn Any issues with this PR? Would love to get this merged in for 0.8.0

michaelbeaumont
michaelbeaumont approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, keithmattix, michaelbeaumont

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

Thanks @keithmattix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit e903291 into kubernetes-sigs:main Aug 23, 2023
@keithmattix keithmattix deleted the mesh-conformance-ipv6 branch August 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@howardjohn howardjohn howardjohn approved these changes

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@mlavacca mlavacca Awaiting requested review from mlavacca

@kflynn kflynn Awaiting requested review from kflynn

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keithmattix @k8s-ci-robot @shaneutt @robscott @howardjohn @michaelbeaumont