Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gwctl get gateways #2782

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Implement gwctl get gateways #2782

merged 1 commit into from
Feb 23, 2024

Conversation

jongwooo
Copy link
Member

@jongwooo jongwooo commented Feb 17, 2024

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Implement gwctl get gateways.

Output Columns Description Visibility
NAME Name of the Gateway
CLASS Class of the Gateway
ADDRESSES Addresses of the Gateway (displayed using +n more)
PORTS Ports exposed by the Gateway
PROGRAMMED Whether the Gateway is programmed
AGE Age of the Gateway
POLICIES Count of policies affecting this Gateway -o wide
HTTPROUTES Count of HTTPRoutes that are attached to this Gateway -o wide

The -o wide format is not yet implemented, so the columns POLICIES, HTTPROUTES are excluded.

Which issue(s) this PR fixes:

Fixes #2778

Does this PR introduce a user-facing change?:

Implement `gwctl get gateways`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@gauravkghildiyal
Copy link
Member

This looks great! Thanks @jongwooo!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit d02abe6 into kubernetes-sigs:main Feb 23, 2024
8 checks passed
@jongwooo jongwooo deleted the implement-gwctl-get-gateways branch February 23, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gwctl get gateways
3 participants