feat: conformance report summary field #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
mlavacca
force-pushed
the
report-summary
branch
from
f5ff512 to
bf09a10
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
report-summary
branch
from
bf09a10 to
e20f560
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
shaneutt
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Thanks @mlavacca! I assume we've already tested this out on an implementation?
/approve
/cc @youngnick @robscott
Yes, this has been tested with the Kong Ingress Controller |
sunjayBhatia
approved these changes
Feb 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @mlavacca! /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area conformance
What this PR does / why we need it:
The conformance report
.profiles[*].summaryfield is now automatically filled by the conformance test suite with a human-readable message about the outcome of the tests run.Which issue(s) this PR fixes:
Fixes #2235
Does this PR introduce a user-facing change?: