Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing columns to gwctl get httproutes #2805

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add missing columns to gwctl get httproutes #2805

merged 1 commit into from
Mar 4, 2024

Conversation

jongwooo
Copy link
Member

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Add missing columns to gwctl get httproutes.

Output Columns Description Visibility
NAMESPACE Namespace of the HTTPRoute
NAME Name of the HTTPRoute
HOSTNAMES Hostnames associated with the HTTPRoute
PARENT REFS Count of parent references of the HTTPRoute (e.g., Gateways)
AGE Age of the HTTPRoute
POLICIES Count of policies affecting this HTTPRoute -o wide

Which issue(s) this PR fixes:

Fixes #2804

Does this PR introduce a user-facing change?:

Add missing columns to `gwctl get httproutes`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2024
gauravkghildiyal
gauravkghildiyal reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jongwooo! Mostly looks good...just some thoughts for better testing in the long run.

gwctl/pkg/printer/httproutes.go Outdated Show resolved Hide resolved
@gauravkghildiyal
Copy link
Member

/assign

@jongwooo jongwooo marked this pull request as draft February 27, 2024 00:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@jongwooo
Copy link
Member Author

I'll work on injecting the fack clock during testing.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
@jongwooo jongwooo marked this pull request as ready for review February 27, 2024 00:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@jongwooo jongwooo mentioned this pull request Feb 27, 2024
Merged
@jongwooo
Copy link
Member Author

I'll work on injecting the fack clock during testing.

For gwctl get gateways, it has already been pushed to the main branch, so we need to handle #2822 first.

@gauravkghildiyal
Copy link
Member

I believe this was accidentally closed by the other merge

/reopen

@k8s-ci-robot
Copy link
Contributor

@gauravkghildiyal: Reopened this PR.

In response to this:

I believe this was accidentally closed by the other merge

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
gauravkghildiyal
gauravkghildiyal reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @jongwooo. Thanks! (Just one small optional suggestion)

Let me know once you rebase to fix the conflict.

gwctl/pkg/printer/httproutes_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
@jongwooo
Add missing columns to gwctl get httproutes
7d993d9 
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo mentioned this pull request Mar 2, 2024
Merged
@gauravkghildiyal
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit bfac91b into kubernetes-sigs:main Mar 4, 2024
8 checks passed
@jongwooo jongwooo deleted the add-missing-columns-to-gwctl-get-httproutes branch March 4, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravkghildiyal gauravkghildiyal gauravkghildiyal left review comments

Assignees

@gauravkghildiyal gauravkghildiyal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing columns to gwctl get httproutes
3 participants
@jongwooo @gauravkghildiyal @k8s-ci-robot