Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gwctl get gatewayclass #2847

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Implement gwctl get gatewayclass #2847

merged 1 commit into from
Mar 8, 2024

Conversation

jongwooo
Copy link
Member

@jongwooo jongwooo commented Mar 6, 2024

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Implement gwctl get gatewayclass.

Output Columns Description Visibility
NAME Name of the GatewayClass
CONTROLLER Controller managing the GatewayClass
ACCEPTED Whether the GatewayClass is accepted by the controller
AGE Age of the Policy CRD
GATEWAYS Count of Gateways using this GatewayClass -o wide
DESCRIPTION Description from the GatewayClass -o wide

The -o wide format is not yet implemented, so the columns GATEWAYS, DESCRIPTION are excluded.

Which issue(s) this PR fixes:

Fixes #2846

Does this PR introduce a user-facing change?:

Implement `gwctl get gatewayclass`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2024
@gauravkghildiyal
Copy link
Member

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@gauravkghildiyal
Copy link
Member

Neat! Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit b4f0307 into kubernetes-sigs:main Mar 8, 2024
8 checks passed
@jongwooo jongwooo deleted the implement-gwctl-get-gatewayclass branch March 8, 2024 10:04
hanxiaop pushed a commit to hanxiaop/gateway-api that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gwctl get gatewayclass
3 participants