-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing v1alpha2 directory from docs #2965
Removing v1alpha2 directory from docs #2965
Conversation
32287dc
to
901c8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there still a TLS guide to moved? It used to be in v1alpha2 but I don't see it moved in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, these were all just symlinks so everything in the directory would have been a copy with the main guides directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I see that these files were just redirects to the folder above.
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
901c8dc
to
eb4f2f9
Compare
I think Prow is confused, I just rebased this and GitHub UI is not asking for rebase. Maybe this will wake it up. /honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The v1alpha2 directory in our docs existed to prevent any old/outdated links from breaking, but I think we've outlived it's usefulness. I'd expect that anything linking to an old v1alpha2 URL is likely several years out of date. This removes that older structure to simplify managing our docs. Thanks to @candita for catching this one!
Does this PR introduce a user-facing change?: